meven added a comment.
FYI on this patch serie, I am currently focusing on the specification work : https://gitlab.freedesktop.org/xdg/xdg-specs/-/merge_requests/35 Then I am thinking about moving my patch serie to gitlab reflecting on the last feedback of course. Those patchs are getting old and are going to need some degree of rebasing. INLINE COMMENTS > meven wrote in previewjob.cpp:754 > Maybe add it optionally, when different from 1 Not needed. > bruns wrote in previewjob.cpp:699 > mixing floating point and integers for a memory-allocation like function is a > real bad idea. I am thinking about making devicePixelRatio an int. > previewjob.h:196 > + * > + * @since 5.71 > + */ update > dfaure wrote in thumbcreator.h:191 > 5.70 is tagged already update REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29397 To: meven, dfaure, broulik, #frameworks, ngraham Cc: bruns, elvisangelaccio, kossebau, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham