-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115725/#review49785
-----------------------------------------------------------


This review has been submitted with commit 
ff1475fe9b64de8a79a2cc7d723f6152cb3ad71c by Aurélien Gâteau to branch master.

- Commit Hook


On Feb. 13, 2014, 2:22 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115725/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2014, 2:22 p.m.)
> 
> 
> Review request for KDE Frameworks and Alex Merry.
> 
> 
> Repository: kapidox
> 
> 
> Description
> -------
> 
> Yapgvb turned out to be painful to deploy, and Ben pointed out that Graphviz 
> provides official Python bindings. Those are less Pythonic, but more 
> widespread and it is safe to assume they are maintained. Switching to those 
> bindings also allow us to avoid temporary files, which is a nice bonus.
> 
> I actually made the changes in two patches: one to switch to gv, the other to 
> remove the temp files.
> 
> 
> Diffs
> -----
> 
>   README.md b88dde0 
>   src/kapidox/depdiagram/frameworkdb.py 8cba5e6 
>   src/kapidox/depdiagram/gvutils.py PRE-CREATION 
>   src/kgenframeworksapidox e684320 
> 
> Diff: https://git.reviewboard.kde.org/r/115725/diff/
> 
> 
> Testing
> -------
> 
> - Generated diagrams with depdiagram-prepare and depdiagram-generate
> - Generated docs with kgenframeworksapidox
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Reply via email to