----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115744/#review49805 -----------------------------------------------------------
This is something where the opinion of the kde-windows team is really needed. The origin of that code traces back to this commit (with a reference https://bugs.kde.org/show_bug.cgi?id=293610): http://quickgit.kde.org/?p=kdelibs.git&a=commit&h=38b5e7f937b5d2c291c5b20a0c8648632084dde5 - Luigi Toscano On Feb. 14, 2014, 12:29 a.m., Alexander Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115744/ > ----------------------------------------------------------- > > (Updated Feb. 14, 2014, 12:29 a.m.) > > > Review request for Documentation, KDE Frameworks, kdewin, and Luigi Toscano. > > > Repository: kdoctools > > > Description > ------- > > The WIN32 part of this if statement doesn't seem to work -> drop it > > The frameworks using KDocTools fail otherwise complaining about invalid > paths (Win32 build) > > Without this patch I get the following error: > > file:///C:/ProgramData/kdoctools5/customization/dtd/kdex.dtd:102: warning: > failed to load external entity > "file:///emerge-root/share/xml/docbook/schema/dtd/4.2/docbookx.dtd" > > The path there is actually correct and should work. However, it seems that > XSLT does not accept paths starting with a / on windows. Using / is fine > and evaluates to the root directory of the current drive. > > > Diffs > ----- > > src/CMakeLists.txt 241d56ffdb9f5cf4859eaf06aad491b9e1ca94fa > > Diff: https://git.reviewboard.kde.org/r/115744/diff/ > > > Testing > ------- > > kservice didn't compile before this change, now it does (win32), doesn't > affect other platforms > > > Thanks, > > Alexander Richardson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel