kossebau added inline comments.

INLINE COMMENTS

> kcombobox.cpp:363
> +        connect(d->klineEdit, &KLineEdit::completionBoxActivated,
> +                this, QOverload<const 
> QString&>::of(&QComboBox::textActivated));
> +#endif

Why the `QOverload<const QString&>::of()` with `&QComboBox::textActivated`? 
Accidental copy&paste?
After all the purpose of the new signals is to get rid of the overloading, no?

REPOSITORY
  R284 KCompletion

REVISION DETAIL
  https://phabricator.kde.org/D23842

To: dfaure, cfeck, dhaumann, aacid, vkrause
Cc: kossebau, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns

Reply via email to