On 21/04/2021 15:34, Ahmad Samir wrote:
On 21/04/2021 15:20, Harald Sitter wrote:
To conclude this our verdict is to always use the modern headers?
I am re-checking the rest of the frameworks that failed the first time around; Albert already
reported that it built for him locally with '#include <cerrno>'; I'll test again, push the changes
and if the CI doesn't barf on any of it, then my conclusion is it's OK so far.
I've now pushed all those changes; only remains:
Deprecated:
kdelibs4support
kjs
kdesu/src/kdesu_stub.c: this stays since this is C code
these two files are generated by some tool, I left them be:
kholidays/src/parsers/plan2/holidayscannerplan.cpp
kholidays/src/parsers/plan2/holidayscannerplan.lpp
kinit/src/kdeinit/kinit_mac.mm: no idea about mac, can't test, so didn't change
it
kinit/src/start_kdeinit/start_kdeinit.c: C code
They seemed to build fine on the CI.
--
Ahmad Samir
