----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115710/#review50347 -----------------------------------------------------------
Please address David's comments, I think this patch is interesting and shouldn't stay in limbo too long. - Kevin Ottens On Feb. 12, 2014, 11:28 p.m., David Gil Oliva wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115710/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2014, 11:28 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kcompletion > > > Description > ------- > > Hide private methods and slots behind the d-pointer in KHistoryComboBox > > Also: > -Remove header not used > > > Diffs > ----- > > src/khistorycombobox.h 3667eb4 > src/khistorycombobox.cpp 6f81dda > > Diff: https://git.reviewboard.kde.org/r/115710/diff/ > > > Testing > ------- > > It builds. Tests pass. > > > Thanks, > > David Gil Oliva > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
