----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115485/#review50532 -----------------------------------------------------------
This review has been submitted with commit 6d405c31ac624b4ea8b7144a83cd3c04b3e38a25 by Kevin Krammer to branch master. - Commit Hook On Feb. 22, 2014, 2 p.m., Kevin Krammer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115485/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2014, 2 p.m.) > > > Review request for KDE Frameworks and Chusslove Illich. > > > Repository: ki18n > > > Description > ------- > > Attempt at replacing the KJS dependency with a QtScript, i.e. making ki18n a > tier1 framework. > Needs more testing and likely fixing > > > Diffs > ----- > > autotests/CMakeLists.txt c4d6b9b > src/CMakeLists.txt 9e3ce9f > src/ktranscript.cpp b9e0551 > CMakeLists.txt 06fb696 > > Diff: https://git.reviewboard.kde.org/r/115485/diff/ > > > Testing > ------- > > Unittest runs, but the test script is very minimal and would need to be > extendedb by someone who understands the scripting requirements. > There is also a weird crash at test shutdown, in QThreadStorage. As far as I > can tell I did not change anything related to threads though. > > > Thanks, > > Kevin Krammer > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
