> On Feb. 22, 2014, 6:29 p.m., Luigi Toscano wrote: > > As this was already committed, can this RR be closed? > > Alex Merry wrote: > Actually, I never committed this one, since I never got a ship it. I > added the files to kdoctools, but never removed them from e-c-m.
Is a shipit really needed, given https://git.reviewboard.kde.org/r/115896/ ? - Luigi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115897/#review50553 ----------------------------------------------------------- On Feb. 19, 2014, 11:45 p.m., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115897/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2014, 11:45 p.m.) > > > Review request for Build System, Extra Cmake Modules, KDE Frameworks, David > Faure, Kevin Ottens, and Luigi Toscano. > > > Repository: extra-cmake-modules > > > Description > ------- > > Remove FindDocBook*.cmake > > These are only really useful to kdoctools, so they may as well live > there. > > (NB: after looking at how kdoctools uses the information from these files, I > suspect they won't even be needed for the compatibility macros that are > intended to end up in kde4support). > > > Diffs > ----- > > find-modules/FindDocBookXML.cmake b6d623e4e5ca40cdda4c895a19a0dc273831703a > find-modules/FindDocBookXSL.cmake a7320aed66b72c92f0286658e38b7fc32266790c > > Diff: https://git.reviewboard.kde.org/r/115897/diff/ > > > Testing > ------- > > > Thanks, > > Alex Merry > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel