----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115983/#review50616 -----------------------------------------------------------
Ship it! Ship It! - Chusslove Illich On Feb. 23, 2014, 10:52 p.m., Kevin Krammer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115983/ > ----------------------------------------------------------- > > (Updated Feb. 23, 2014, 10:52 p.m.) > > > Review request for KDE Frameworks and Chusslove Illich. > > > Repository: ki18n > > > Description > ------- > > Create the script engine as a QObject child of the interface and > delete all interfaces in KTranscriptImp's destructor. > > valgrind --tool=memcheck ./ktranscripttest > > before: > > > ==10664== HEAP SUMMARY: > ==10664== in use at exit: 445,913 bytes in 2,753 blocks > ==10664== total heap usage: 27,995 allocs, 25,242 frees, 6,059,328 bytes > allocated > ==10664== > ==10664== LEAK SUMMARY: > ==10664== definitely lost: 0 bytes in 0 blocks > ==10664== indirectly lost: 0 bytes in 0 blocks > ==10664== possibly lost: 1,488 bytes in 3 blocks > ==10664== still reachable: 444,425 bytes in 2,750 blocks > ==10664== suppressed: 0 bytes in 0 blocks > > > after: > > ==11788== HEAP SUMMARY: > ==11788== in use at exit: 13,778 bytes in 66 blocks > ==11788== total heap usage: 28,003 allocs, 27,937 frees, 6,064,040 bytes > allocated > ==11788== > ==11788== LEAK SUMMARY: > ==11788== definitely lost: 0 bytes in 0 blocks > ==11788== indirectly lost: 0 bytes in 0 blocks > ==11788== possibly lost: 1,488 bytes in 3 blocks > ==11788== still reachable: 12,290 bytes in 63 blocks > ==11788== suppressed: 0 bytes in 0 blocks > > > Diffs > ----- > > src/ktranscript.cpp 1ce0d1a > > Diff: https://git.reviewboard.kde.org/r/115983/diff/ > > > Testing > ------- > > All tests still run successfully > > > Thanks, > > Kevin Krammer > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel