----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116461/ -----------------------------------------------------------
Review request for KDE Frameworks and Matthew John Dawson. Repository: kconfig Description ------- KConfigSkeleton: avoid calling reparseConfiguration() immediately after creation. KConfig already parses the config files from disk in the constructor, which is necessary for non-KConfigXT users. However when using KConfigXT the first thing one has to do after creation is to call readConfig(), which should therefore not call reparseConfiguration the first time. strace -e open kate |& grep -v NOENT | grep oxygenrc | wc -l went from 4 to 1 --> bingo, goal reached! (and when looking for kdeglobals, from 10 to 7) Diffs ----- src/core/kcoreconfigskeleton.cpp 9c5fb4a80d500e81b483b749a137ad5f2c99a55f src/core/kcoreconfigskeleton_p.h 0b020ed3493186e699d872ddc7a9f9294d797a95 Diff: https://git.reviewboard.kde.org/r/116461/diff/ Testing ------- (see commit log) + unittests in kconfig still pass. Thanks, David Faure
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
