----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116098/#review51909 -----------------------------------------------------------
Ship it! Ship It! - Lamarque Souza On March 4, 2014, 4:13 p.m., Alexander Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116098/ > ----------------------------------------------------------- > > (Updated March 4, 2014, 4:13 p.m.) > > > Review request for KDE Frameworks, Daniel Nicoletti, Lamarque Souza, and > Sebastian Kügler. > > > Repository: libnm-qt > > > Description > ------- > > Drop unneccessary dependency on extra-cmake-modules and use GNUInstallDirs > > This means there is no longer a need for passing -DLIB_SUFFIX=64 on e.g. > openSuSE, since CMake will detect the correct install directory for most > distributions. If for some reason CMake doesn't detect the correct > directory it can be overriden using e.g. -DCMAKE_INSTALL_LIBDIR=lib32 > > > Diffs > ----- > > CMakeLists.txt 9918278 > NetworkManagerQt.pc.cmake 2c3ab07 > include/CMakeLists.txt 2b51ced > include/settings/CMakeLists.txt 1a00bdb > > Diff: https://git.reviewboard.kde.org/r/116098/diff/ > > > Testing > ------- > > Installed into the right directories after applying the patch. > > > Thanks, > > Alexander Richardson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel