----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115977/#review51936 -----------------------------------------------------------
src/karchive.h <https://git.reviewboard.kde.org/r/115977/#comment36925> Hm, why the change to "" for the includes? We try to stick to <> in public headers. - Kevin Ottens On Feb. 23, 2014, 7:15 p.m., Harald Fernengel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115977/ > ----------------------------------------------------------- > > (Updated Feb. 23, 2014, 7:15 p.m.) > > > Review request for KDE Frameworks. > > > Repository: karchive > > > Description > ------- > > Change CMakeLists.txt to create Mac OS X frameworks > > > Diffs > ----- > > CMakeLists.txt f5dc644fdba13e29c94940c77d628e92e0759787 > src/CMakeLists.txt 53e97284cab199f5eb75aa276adfadc18d677682 > src/karchive.h d4209cf334190dda735fcb4687fa102a4e7a73cd > src/karchivedirectory.h 60225d0be9fc2e28ff2b998dcc8fb28512c6e3cd > src/karchiveentry.h aad6840ee0dc22e5760ddda99ce975a1d9a9dc92 > src/karchivefile.h c7d2e0e0735f75a8e490082aa8598fd08206a998 > src/ktar.h 4bca89884e646ffae90aa1a9e15a985e998e843f > > Diff: https://git.reviewboard.kde.org/r/115977/diff/ > > > Testing > ------- > > 'make install' on Mac OS X > > > Thanks, > > Harald Fernengel > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel