----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116088/#review52032 -----------------------------------------------------------
This review has been submitted with commit 1332dd022f1e1fc88abe10ce9a9cb89d1cddcaf2 by Aurélien Gâteau to branch master. - Commit Hook On Feb. 27, 2014, 12:19 p.m., Aurélien Gâteau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116088/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2014, 12:19 p.m.) > > > Review request for KDE Frameworks. > > > Repository: knotifications > > > Description > ------- > > Remove FindDBusMenuQt5.cmake > > dbusmenu-qt ships a CMake config file so we don't need a Find* file anymore. > Unfortunately the target defined does not set the include dir so for the > time being it is still necessary to call include_directories() > (might look into this if I find time) > > > Diffs > ----- > > CMakeLists.txt ef84eb6 > cmake/FindDBusMenuQt5.cmake 7d43489 > src/CMakeLists.txt 900cb38 > > Diff: https://git.reviewboard.kde.org/r/116088/diff/ > > > Testing > ------- > > Builds, manual tests run as expected. > > > Thanks, > > Aurélien Gâteau > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel