> On March 5, 2014, 12:31 p.m., Alex Merry wrote: > > Note that find_package(Wayland COMPONENTS Client Egl) *should* fail. What > > shouldn't fail is find_package(Wayland OPTIONAL_COMPONENTS Client Egl).
I hadn't realised that about pkg_check_modules(), though. I'll have to update the docs I wrote. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116598/#review52067 ----------------------------------------------------------- On March 5, 2014, 9 a.m., Aurélien Gâteau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116598/ > ----------------------------------------------------------- > > (Updated March 5, 2014, 9 a.m.) > > > Review request for Build System, Extra Cmake Modules, KDE Frameworks, and > Martin Gräßlin. > > > Repository: extra-cmake-modules > > > Description > ------- > > First part of the diff makes sure find_package_handle_standard_args() gets a > version number to check against. > > Second part ensures we get proper results from pkg-config even if not all > components are available. find_package(Wayland COMPONENTS Client Egl) was > failing for me because I have Client installed but not Egl, causing > pkg_check_modules() to not set any PKG_Wayland_${comp} variable. > > > Diffs > ----- > > find-modules/FindWayland.cmake 21014fc > > Diff: https://git.reviewboard.kde.org/r/116598/diff/ > > > Testing > ------- > > Together with a change for kde-workspace, it fixes the build of kde-workspace > on my system with wayland-client 1.1 and no wayland-egl. > > > Thanks, > > Aurélien Gâteau > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
