> On March 14, 2014, 9:18 a.m., David Faure wrote: > > src/kcompletionbox.h, line 229 > > <https://git.reviewboard.kde.org/r/116747/diff/4/?file=253685#file253685line229> > > > > That two 'd's too many.
Aaargh!! I added those two d's for refactoring and then I forgot to change it (actually I forgot two times, because one of the reviewers already told me)... The next time I will use something that doesn't compile. I'm sorry, I program at night and lately I'm usually very tired (I just had a baby three months ago). - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116747/#review52928 ----------------------------------------------------------- On March 13, 2014, 10:13 p.m., David Gil Oliva wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116747/ > ----------------------------------------------------------- > > (Updated March 13, 2014, 10:13 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kcompletion > > > Description > ------- > > Clean up KCompletionBox > > -canceled() -> cancelled (private method) > -Deprecate sizeAndPosition() --> resizeAndReposition() > -Remove old comments and commented-out code > -Move some slots to be normal methods, since they don't seem to be able to > work as slots. > > > Diffs > ----- > > src/kcompletionbox.h 09b7527 > src/kcompletionbox.cpp 92e87b3 > > Diff: https://git.reviewboard.kde.org/r/116747/diff/ > > > Testing > ------- > > It builds and tests pass. > > > Thanks, > > David Gil Oliva > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
