----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116087/#review52938 -----------------------------------------------------------
src/kcrash.cpp <https://git.reviewboard.kde.org/r/116087/#comment37256> A stylistic point: I think removing the blank lines makes it harder to read src/kcrash.cpp <https://git.reviewboard.kde.org/r/116087/#comment37257> I think it might be worth documenting (in a comment) the assumption that the main/GUI thread is stopped, and so no windows will be created, and so the startupid won't go away. - Alex Merry On March 14, 2014, 12:38 p.m., Alexander Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116087/ > ----------------------------------------------------------- > > (Updated March 14, 2014, 12:38 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: kcrash > > > Description > ------- > > remove usage of strlcpy > > We can get the startupId from the QPlatformNativeInterface. > Additionally this means we no longer need to link to KWindowSystem. > > REVIEW: 116087 > > > Diffs > ----- > > CMakeLists.txt b9a6f441abed3c88bf428869c30ef5aebd72fc74 > KF5CrashConfig.cmake.in dcde84376e7ea69e53a26dc2bcba8137ee28a2a4 > src/CMakeLists.txt d19b97f98e057d5537cf0eb6a8e1997d2a24cb1e > src/config-strlcpy.h.cmake 5d9163d7a60d89b9792afcdf498af6425a9038a8 > src/kcrash.cpp 6c41022206130f186d52ddbb77afd58c429f368f > src/strlcpy-fake.c 9b2dc68c466908d11370ba0c4bbe8d315962da5d > > Diff: https://git.reviewboard.kde.org/r/116087/diff/ > > > Testing > ------- > > Compiles > > > Thanks, > > Alexander Richardson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel