----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116786/#review52951 -----------------------------------------------------------
src/meinproc.cpp <https://git.reviewboard.kde.org/r/116786/#comment37262> (spotted by Pino, thanks) could you please wrap the definition of the body of DIE using the 'do {} while(0)' syntax? http://stackoverflow.com/questions/257418/do-while-0-what-is-it-good-for After that, feel free to commit and thanks again! - Luigi Toscano On March 14, 2014, 12:54 p.m., Aurélien Gâteau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116786/ > ----------------------------------------------------------- > > (Updated March 14, 2014, 12:54 p.m.) > > > Review request for Documentation, KDE Frameworks and Luigi Toscano. > > > Repository: kdoctools > > > Description > ------- > > This should makes it easier to interpret future failures, for example by not > running xmllint if catalogs are missing. > > > Diffs > ----- > > src/meinproc.cpp 22150ab > > Diff: https://git.reviewboard.kde.org/r/116786/diff/ > > > Testing > ------- > > Clean-rebuilt all frameworks which depends on kdoctools, plus kde-runtime, > kde-workspace, konsole, kate. > > > Thanks, > > Aurélien Gâteau > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel