----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116787/#review52957 -----------------------------------------------------------
looks good to me, just a few minor nitpicks. Most is: prefer using XCB_WINDOW_NONE instead of XCB_NONE if it's a window type. Similar there is XCB_ATOM_NONE, etc. etc. Would you mind adding a unit test for it? Would be nice to have this covered and I wouldn't be surprised if that will become an issue for other platforms, too. Thus a unit test will catch it before the implementation is finished. src/kwindowsystem_x11.cpp <https://git.reviewboard.kde.org/r/116787/#comment37276> nitpick: Q_NULLPTR src/kwindowsystem_x11.cpp <https://git.reviewboard.kde.org/r/116787/#comment37275> nitpick: XCB_WINDOW_NONE src/kwindowsystem_x11.cpp <https://git.reviewboard.kde.org/r/116787/#comment37273> nitpick: XCB_WINDOW_NONE src/kwindowsystem_x11.cpp <https://git.reviewboard.kde.org/r/116787/#comment37274> nitpick: XCB_WINDOW_NONE - Martin Gräßlin On March 14, 2014, 11:36 a.m., Aaron J. Seigo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116787/ > ----------------------------------------------------------- > > (Updated March 14, 2014, 11:36 a.m.) > > > Review request for KDE Frameworks, kwin and Martin Gräßlin. > > > Repository: kwindowsystem > > > Description > ------- > > When using KWindowInfo from a thread other than the main application thread, > the application fails on an assert triggered by creating a QWidget in another > thread. This is due to NETEventFilter being a QWidget. This patch addresses > the issue by using a QObject to create the NETEventFilter, which is itself > first moved to the main application thread. > > > Diffs > ----- > > src/kwindowsystem.cpp 4c17baa > src/kwindowsystem_p_x11.h 75f3028 > src/kwindowsystem_x11.cpp 95c396b > > Diff: https://git.reviewboard.kde.org/r/116787/diff/ > > > Testing > ------- > > Used in the Sprinter Windows plugin and works lovely to find desktops, > windows, etc. > > > Thanks, > > Aaron J. Seigo > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
