----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116866/#review53279 -----------------------------------------------------------
In general, I would prefer configure-time checks for the presence of these functions, rather than using Q_CC_ defines. See KJS for examples of these tests. - Alex Merry On March 17, 2014, 8:53 p.m., Michael Hansen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116866/ > ----------------------------------------------------------- > > (Updated March 17, 2014, 8:53 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kguiaddons > > > Description > ------- > > Use std::isnan from <cmath> instead of isnan from <math.h>, as MinGW-32 on > Windows does not include the latter. This keeps the _isnan hack for MSVC, > since that compiler doesn't include either standard version :(. > > > Diffs > ----- > > src/colors/kcolorutils.cpp 7df25b3d7acbb65b29513d2139d7b83de53ee4c2 > > Diff: https://git.reviewboard.kde.org/r/116866/diff/ > > > Testing > ------- > > Compiled with MSVC10 (32-bit), MinGW 4.8 (32-bit, Windows native), and GCC > 4.8 (Arch x86_64). > > > Thanks, > > Michael Hansen > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel