> On March 22, 2014, 11:21 p.m., Nicolás Alvarez wrote: > > I can't test this because the kservice framework (dep of kinit) doesn't > > compile on Windows. > > Alex Merry wrote: > Yeah... I was operating on the basis of "this is probably less broken > than before". kwrapper_win.cpp also has some defunct stuff in it, I guess > for much the same reason.
I'll test this tomorrow. I thought kservice works on windows (https://git.reviewboard.kde.org/r/115745/), what's the error? - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116984/#review53773 ----------------------------------------------------------- On March 22, 2014, 9:46 p.m., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116984/ > ----------------------------------------------------------- > > (Updated March 22, 2014, 9:46 p.m.) > > > Review request for KDE Frameworks and Alexander Richardson. > > > Repository: kinit > > > Description > ------- > > Fix configuring of kde5init_win32lib_dummy.cpp.in > > The code referred to a variable that was no longer set, so couldn't > possibly produce correct code. This sets the variable again (and > renames it). > > > Diffs > ----- > > KF5InitMacros.cmake dddc230341cfb481955a9308e1b4700aa335f940 > kde5init_win32lib_dummy.cpp.in 0c030adb0835a291d98ac91b558a08f50f0d448a > > Diff: https://git.reviewboard.kde.org/r/116984/diff/ > > > Testing > ------- > > Completely untested, as I don't use Windows. > > > Thanks, > > Alex Merry > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel