----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116962/#review53841 -----------------------------------------------------------
Ship it! - David Faure On March 21, 2014, 6:15 p.m., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116962/ > ----------------------------------------------------------- > > (Updated March 21, 2014, 6:15 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kconfig > > > Description > ------- > > Update docs for KDesktopFile::isAuthorizedDesktopFile() > > The fact that it changed in KDE 4.3 is not so relevant any more. > > Remove unhelpful comments > > These lines of code do not really require any justification. > > Better comment for why KDesktopFile::readPath uses readEntry > > > Remove old kdelibs4 code > > All this ifdef'd-out code just makes it hard to see what's going on. > > Remove references to ${_KDE4_KCONFIG_COMPILER_DEP} > > Not sure why it would be unset and then used, instead of just not used > at all. LXR says it's not used anywhere else, though. > > > Diffs > ----- > > KF5ConfigConfig.cmake.in 12ff7c639493f75ed0c5941c40604d00e7a1b047 > KF5ConfigMacros.cmake aeebee9ea39ab33712131b13ca561136a9bb6309 > src/core/kconfig.cpp 4695621ab4c4dbc862c0ddde1b065e19254ab500 > src/core/kdesktopfile.h df8eff1a796ead2b19e1c7bcca2a7b7d22e34d34 > src/core/kdesktopfile.cpp ea0419f6acf572f3c9a48bb77704b2d7d71e4ad4 > src/kconf_update/kconf_update.cpp f8ba16d1c27029b480f19d5580b3edca9ac98bd0 > src/kconfig_compiler/CMakeLists.txt > 71f2609d870cd00eae3d98c0f3a07504d5973ff0 > > Diff: https://git.reviewboard.kde.org/r/116962/diff/ > > > Testing > ------- > > > Thanks, > > Alex Merry > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel