> On March 17, 2014, 4:44 p.m., Kevin Ottens wrote: > > OK, let's go for it without a test app...
Anything still blocking? - Kevin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115717/#review53187 ----------------------------------------------------------- On Feb. 13, 2014, 9:41 a.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115717/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2014, 9:41 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kdesu > > > Description > ------- > > Do not require to have a DISPLAY env variable if WAYLAND_DISPLAY is set > > If kdesu is compiled with X11 it required the DISPLAY variable to be > set. This is no longer correct as it might have been compiled with > X11 but is run on Wayland. Thus the code checks now also for > WAYLAND_DISPLAY in the HAVE_X11 ifdef blocks. The Wayland support > should become more complete, I do not know how it behaves if we compile > without X11 support. Unfortunately there are no autotests and no test > applications which one could use. > > > Diffs > ----- > > src/client.cpp 91bfd78fbca6e5d8d365d924c0260087e3937948 > src/kcookie.cpp 59448351696c503b34b7507e9c3fa8efc53139f9 > > Diff: https://git.reviewboard.kde.org/r/115717/diff/ > > > Testing > ------- > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel