> On March 24, 2014, 11:01 a.m., Aleix Pol Gonzalez wrote: > > What about QStandardPaths::findExecutable? Actually this one should look > > into libexec too (at least the equivalent KStandardDirs::findExe used to). > > Alex Merry wrote: > I'm pretty sure QStandardPaths won't look at libexec. How should it know > where libexec stuff is? The whole point of libexec is that it is > library-private (TBH it's slightly hacky to have a "kde5" libexec dir in > $LIB/kde5/libexec; really, each library should have its own dir). > > Hrvoje Senjan wrote: > additionally, i think this will actually open drkonqi(4) (if > kde-runtime(4) is also installed), no? > > Dan Vrátil wrote: > The idea is that it does not find anything and fallsback to > CMAKE_INSTALL_DIR/LIBEXEC_INSTALL_DIR, but allows us to override it by PATH > in case we use some prefix, like /opt/kde5. Obviously if people mess with > their PATH they might get weird results like starting drkonqi4, but that's > simply their problem.
If anything, I'd rather use a special variable rather than PATH. Putting things onto PATH that weren't named with that in mind is asking for trouble, IMO. Maybe "KCRASH_DRKONQI_EXECUTABLE"? - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117016/#review53939 ----------------------------------------------------------- On March 24, 2014, 12:01 p.m., Dan Vrátil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117016/ > ----------------------------------------------------------- > > (Updated March 24, 2014, 12:01 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kcrash > > > Description > ------- > > Since KCrash is a framework that relies on DrKonqi binary being provided by a > 3rd party software (kde-runtime), it should not make assumptions regarding > location of the utility. > > This patch makes KCrash to look for drkonqi binary first in $PATH, then > falling back to CMAKE_INSTALL_PREFIX/LIBEXEC_INSTALL_DIR. With this patch > it's possible for distributions to ship KDE Frameworks in normal prefix > (/usr), but have current snapshots of kde-runtime in /opt/kde5 for instance. > > > Diffs > ----- > > src/kcrash.cpp 87163cc > > Diff: https://git.reviewboard.kde.org/r/117016/diff/ > > > Testing > ------- > > - Installed KCrash into /usr prefix > - Installed drkonqi from kde-runtime master to /opt/kde5 prefix > - started broken application > - no "could not find drkonqi" warning anymore > - crashed application, got drkonqi window > > > Thanks, > > Dan Vrátil > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel