----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117102/#review54341 -----------------------------------------------------------
This review has been submitted with commit 82f6257f12b8c3cad8d474fcc4cd05ac5b96a4fa by Alex Merry to branch master. - Commit Hook On March 26, 2014, 10:55 p.m., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117102/ > ----------------------------------------------------------- > > (Updated March 26, 2014, 10:55 p.m.) > > > Review request for KDE Frameworks and Martin Gräßlin. > > > Repository: kwindowsystem > > > Description > ------- > > Remove unused methods from KStartupInfo > > These were related to the startup notification handling of KApplication, > which is now dealt with by the xcb Qt plugin. > > > According to LXR, nothing uses disableAutoAppStartedSending, and only > KApplication and KUniqueApplication in kde4support use > handleAutoAppStartedSending (see the RR this depends on). > > I'm not exactly sure what to do with the other application-side (as opposed > to workspace-side) startup notification things in that class. We probably > want to query the xcb plugin, and we probably want to retain the ability to > manually remove notifications after startup. > > > Diffs > ----- > > src/kstartupinfo.h 9c7cf80ea71f639921f2ea42ee9c748284900a3e > src/kstartupinfo.cpp 605dca286c02666fdcd2825bcb0543c3865695b4 > > Diff: https://git.reviewboard.kde.org/r/117102/diff/ > > > Testing > ------- > > Builds, kstartupinfo test passes. > > > Thanks, > > Alex Merry > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
