----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117161/#review54645 -----------------------------------------------------------
This review has been submitted with commit 018bd82acaf7734126a4fe21f8a54b11a398407b by Aleix Pol to branch master. - Commit Hook On March 29, 2014, 7:25 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117161/ > ----------------------------------------------------------- > > (Updated March 29, 2014, 7:25 p.m.) > > > Review request for KDE Frameworks, Marco Martin and Sebastian Kügler. > > > Repository: plasma-framework > > > Description > ------- > > Drop dependency to QtWidgets from this file. We can start assuming that it > might not be that functional in some platforms. > > Use QGuiApplication counterparts, based mostly on QScreen, which could make > it more powerful in the future. > > I did it because otherwise KAlgebraMobile crashes if using the Plasma > Components based interface. > > > Diffs > ----- > > src/declarativeimports/core/units.cpp f0b8d39 > > Diff: https://git.reviewboard.kde.org/r/117161/diff/ > > > Testing > ------- > > Builds, KAlgebra doesn't have the problem now. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel