On Tue, Apr 1, 2014 at 6:02 PM, Alex Merry <alex.me...@kde.org> wrote:
> This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117274/ > This change has been marked as submitted. > Review request for KDE Frameworks. > By Alex Merry. > > *Updated April 1, 2014, 4:02 p.m.* > *Repository: * kross > Description > > Resurrect the KAboutData for the kross console > > > Use i18n() instead of QCoreApplication::translate() in console app > > This was probably from copy-pasted command-line parsing code; everything > else in this framework uses KI18n. > > Use the correct translation catalog in the console application > > Testing > > Ran kf5kross --help. Not investigated how to test the translation stuff. > > Diffs > > - src/console/CMakeLists.txt (aadc8f57eea53fdd0a51464045b0c12d5dcdb4d2) > - CMakeLists.txt (5b28a3c210232d9682af43afec9401416b858ca0) > - src/console/main.cpp (f81672e1c15681719943f64698ada19eeebc0bef) > > View Diff <https://git.reviewboard.kde.org/r/117274/diff/> > FWIW, I've seen that the context being used in drkonqi is: i18nc("@info:shell", ...). Maybe we want to use that, it looks standard. Aleix
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel