> On April 12, 2014, 10:11 a.m., Alex Merry wrote: > > Would it not make sense to put the compatibility stuff in > > KIO::Job::addMetaData, rather than the slaves? That way it should maintain > > compatibility on both the application and slave side (for slaves shipped > > outside KIO). > > > > Although I guess setMetaData dn mergeMetaData would need the same compat > > hacks... would that be too much of a performance/maintenance hit?
Interesting idea, but yeah, this is rather rarely used metadata, so hacking the central method for it makes me uneasy in terms of performance and maintenance (there are 4 methods: set, add, add, and merge). - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117508/#review55490 ----------------------------------------------------------- On April 12, 2014, 9:55 a.m., David Faure wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117508/ > ----------------------------------------------------------- > > (Updated April 12, 2014, 9:55 a.m.) > > > Review request for KDE Frameworks and Alex Merry. > > > Repository: kio > > > Description > ------- > > KIO metadata: resume -> range-start, resume_until -> range-end. > > This is much more self-explanatory to people wanting to request a byte range, > unrelated to anything like resuming an interrupted download. > > > Diffs > ----- > > docs/metadata.txt b2422f9c816f53d5cec9fbdc0e899329cdb26f30 > src/core/filecopyjob.cpp 7bce804eb516f882bfc53af207245e847a27ad8d > src/core/scheduler.cpp f9bc1482b2b8e66b5880f5875567cd485a5b4a5c > src/core/slavebase.h 7417c5e798d843641886fbea62f330524fd12481 > src/ioslaves/file/file.cpp a642a524c3022ce7f039f90d5bc1f577c88631dc > src/ioslaves/ftp/ftp.cpp 79f6144264c03f506309037ed6e8ce429f6c30f0 > src/ioslaves/http/http.cpp de1a1ddde544229689bd22cd69491a46b8c0dddb > > Diff: https://git.reviewboard.kde.org/r/117508/diff/ > > > Testing > ------- > > > Thanks, > > David Faure > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel