-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117012/
-----------------------------------------------------------
(Updated April 21, 2014, 1:59 a.m.)
Review request for KDE Frameworks and kdewin.
Changes
-------
place all includes under include/KJsEmbed (instead of having another kjsembed
subdir) and remove
"$<INSTALL_INTERFACE:${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed>" from
target_include_directories.
Summary (updated)
-----------------
Place KJsEmbed headers directly under ${INCLUDE_INSTALL_DIR}/KJsEmbed instead
of under ${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed [was: Place KJsEmbed
camelcase header under ${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed]
Repository: kjsembed
Description
-------
Currently kjsembed CMake file tries to install both
${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed (directory) and
${INCLUDE_INSTALL_DIR}/KJsEmbed/KJsEmbed (camel case header). This is not
allowed in a case-insensitive filesystem, causing the install step to fail on
Windows.
Diffs (updated)
-----
src/kjsembed/CMakeLists.txt e0ab74c
Diff: https://git.reviewboard.kde.org/r/117012/diff/
Testing
-------
Tested using MSVC 2013
Thanks,
Andrius da Costa Ribas
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
