----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117581/ -----------------------------------------------------------
(Updated April 21, 2014, 9:47 p.m.) Review request for Build System, Extra Cmake Modules and KDE Frameworks. Changes ------- Remove, rather than deprecate, the module (as aacid and dfaure suggested). Summary (updated) ----------------- Remove ECMDBusAddActivationService module Repository: extra-cmake-modules Description (updated) ------- Remove ECMDBusAddActivationService module ecm_dbus_add_activation_service() requires suffient knowledge of its internals to use that replacing two lines with one seems silly. In order to use it you have to know it behaves like configure_file() (because you have to construct the file yourself), except that it also installs it somewhere (for which you have to make sure DBUS_SERVICES_INSTALL_DIR is defined before you use it, which is certainly not a given for non-KDE projects). By this point, why not just use configure_file() and install()? The DBUS_SERVICES_INSTALL_DIR provided by KDEInstallDirs is all the magic you actually need, and if that's explicit in the CMakeLists.txt file, it's a lot more obvious that you should have it defined somewhere. Diffs (updated) ----- docs/module/ECMDBusAddActivationService.rst 2052faebb01ee7085279fe812aa6f7e100830a3c modules/ECMDBusAddActivationService.cmake 128482e35f9f15025868f3e283db839556a0ce82 Diff: https://git.reviewboard.kde.org/r/117581/diff/ Testing (updated) ------- Built docs. Thanks, Alex Merry
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
