----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117799/#review56944 -----------------------------------------------------------
Ping? I'm not especially impatient, but in case that it had to be pushed before beta2 I won't be able to do it from Friday on, since I will be some days offline. - David Gil Oliva On April 26, 2014, 11:23 p.m., David Gil Oliva wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117799/ > ----------------------------------------------------------- > > (Updated April 26, 2014, 11:23 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kcompletion > > > Description > ------- > > Clean up private slots > > Some private slots didn't have the _k_* form and some methods with the _k_* > form weren't even used as slots. > > > Diffs > ----- > > src/kcombobox.h 752db2c > src/kcombobox.cpp da31394 > src/kcompletionbox.h 3295c24 > src/kcompletionbox.cpp 7d03d64 > src/khistorycombobox.h ea56358 > src/khistorycombobox.cpp 9e2f0be > src/klineedit.h 705147d > src/klineedit.cpp 9d02c12 > src/klineedit_p.h e544224 > > Diff: https://git.reviewboard.kde.org/r/117799/diff/ > > > Testing > ------- > > It builds. Autotests pass. > > > Thanks, > > David Gil Oliva > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel