> On April 29, 2014, 9:22 a.m., Jonathan Riddell wrote: > > I disagree, ./src/kdecore/entry.desktop gets renamed to kf5_entry.desktop > > on install and installs into /usr/share/locale/en_US/kf5_entry.desktop so > > it is the locale entry.desktop file which has been renamed not the country > > entry.desktop files. renaming them in the language packs is future work. > > > > Jonathan Riddell wrote: > seems country entry.desktop files have also been renamed by someone else, > but that's a separate topic. > > > Aleix Pol Gonzalez wrote: > Yes, that was 689905382be5d2ed36a1cbc15810b323964fa328 in > kdelibs4support. Adding them to see what should we do.
OK. Then don't forget that "future work" .... (renaming the desktop files in l10n-kf5) - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117148/#review56831 ----------------------------------------------------------- On April 29, 2014, 11:10 a.m., Jonathan Riddell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117148/ > ----------------------------------------------------------- > > (Updated April 29, 2014, 11:10 a.m.) > > > Review request for KDE Frameworks, Aleix Pol Gonzalez, Dan Vrátil, and Lukáš > Tinkl. > > > Repository: kconfigwidgets > > > Description > ------- > > entry.desktop got renamed, use the renamed file > https://git.reviewboard.kde.org/r/117087/ > > > Diffs > ----- > > src/klanguagebutton.cpp 9f0c055 > > Diff: https://git.reviewboard.kde.org/r/117148/diff/ > > > Testing > ------- > > > Thanks, > > Jonathan Riddell > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
