----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118014/#review57399 -----------------------------------------------------------
Ship it! Fully correct. I'm afraid this isn't the last KUrl(QString) porting bug :( - David Faure On May 6, 2014, 10:37 a.m., Alexander Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118014/ > ----------------------------------------------------------- > > (Updated May 6, 2014, 10:37 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kio > > > Description > ------- > > Previously when entering /home/alex/.config into the dolphin address bar > which is a KUrlNavigator the result would be http:///home/alex/.config/ > > It seems the issue was a replacing KUrl(QString) with QUrl(QString) instead > of QUrl::fromUserInput(QString) in KUriFilter. > > Added a unit test to make sure this issue no longer happens > > > Diffs > ----- > > autotests/kurlnavigatortest.h f45000fb4ceeea2d74f697610ff748176f95bf9e > autotests/kurlnavigatortest.cpp 6d178d37ea6ec8131f6507b7191b6ff4b68a4dec > src/widgets/kurifilter.cpp b307b213da8a2cacb23269943bcc9021e393464e > > Diff: https://git.reviewboard.kde.org/r/118014/diff/ > > > Testing > ------- > > new unit test passes > > > Thanks, > > Alexander Richardson > >
_______________________________________________ Kde-frameworks-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
