----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117974/#review57784 -----------------------------------------------------------
examples/bzip2gzip/main.cpp <https://git.reviewboard.kde.org/r/117974/#comment40235> Maybe a better idea to use a loop to avoid the readAll? I know that's an example which needs to be kept simple, but that would be a bit more realistic to read a few bytes from the input and write them in the output to not load the memory. - Kevin Ottens On May 3, 2014, 2:54 p.m., Maarten De Meyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117974/ > ----------------------------------------------------------- > > (Updated May 3, 2014, 2:54 p.m.) > > > Review request for KDE Frameworks. > > > Repository: karchive > > > Description > ------- > > 2 extra examples on how to use the KArchive framework. Together with the 2 we > already have most of the basic usage is covered. > unzipper: Shows how to extract files from an archive > bzip2gzip: Example about KCompressionDevice > > They are BSD licensed because I consider that a good license for examples. I > wouldn't mind changing to GPL. > Please let me know how they could be improved. > Readability, comments, variable naming, too simple? > > > Diffs > ----- > > examples/bzip2gzip/CMakeLists.txt PRE-CREATION > examples/bzip2gzip/main.cpp PRE-CREATION > examples/unzipper/CMakeLists.txt PRE-CREATION > examples/unzipper/main.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/117974/diff/ > > > Testing > ------- > > Builds and runs ok. > Easy to read and comprehend. (imho) > > > Thanks, > > Maarten De Meyer > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel