----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118289/#review58454 -----------------------------------------------------------
The original screen shot looks bad, because the bold font looks smaller than the normal font. This might be because of wrong hinting settings, or because of a bad font design. Regarding the scaling factor, CSS recommends 1.2 between sizes. Could you also check, whether it reacts to font size changes? Additionally, a programmer might be surprised, that the specified font size is not respected, so you either need to clarify in the API docs, or create a method "setFontSizeFactor()", which defaults to 1.2, but can be changed back to 1.0. - Christoph Feck On May 26, 2014, 10 a.m., Sebastian Kügler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118289/ > ----------------------------------------------------------- > > (Updated May 26, 2014, 10 a.m.) > > > Review request for KDE Frameworks, KDE Usability and Christoph Feck. > > > Repository: kwidgetsaddons > > > Description > ------- > > Change titlewidget from bold to increased font size > > This patch removes the bold weight from KTitleWidget and makes the text > a bit bigger, improving focus. This is more in line with common > expectations of a title, and it's more in line with Plasma 5's > typography. > > > Diffs > ----- > > src/ktitlewidget.cpp b1f3ca714670a6eaa49048d67221d90d11480cec > > Diff: https://git.reviewboard.kde.org/r/118289/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > titlewidget in systemsettings (before) > > https://git.reviewboard.kde.org/media/uploaded/files/2014/05/24/1f207a1c-eeee-4581-9f75-b2ff87671ee0__titlewidget-ss-before.png > titlewidget in systemsettings (after) > > https://git.reviewboard.kde.org/media/uploaded/files/2014/05/24/0c07a018-cd56-4111-bda6-aafb1ebdcbc1__titlewidget-ss-after.png > titlewidget in kate (before) > > https://git.reviewboard.kde.org/media/uploaded/files/2014/05/24/a3ce0956-4339-495e-9775-e9625b4e0311__titlewidget-kate-before.png > titlewidget in kate (after) > > https://git.reviewboard.kde.org/media/uploaded/files/2014/05/24/616bebac-2bed-4427-9190-02f22d798801__titlewidget-kate-after.png > > > Thanks, > > Sebastian Kügler > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel