----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118486/ -----------------------------------------------------------
Review request for KDE Frameworks and Chusslove Illich. Repository: ki18n Description ------- Put transcript plugin in kf5 subdir and simplify search logic Putting the plugin in a versioned subdirectory ensures there will not be any coinstallability issues with KF6 if it is Qt5-based. Using QPluginLoader to find the plugin makes for simpler, more reliable code. Diffs ----- src/CMakeLists.txt 3099d2d29e43e40ac761694019f06aec41e54147 src/klocalizedstring.cpp 4a4f6f8c1a79d4b101ae3df5e589cb629f4bd596 Diff: https://git.reviewboard.kde.org/r/118486/diff/ Testing ------- Tests pass, but not sure how to test the installed location. Chusslove: do you have a standard way to test the loading and operation of the transcript plugin? Thanks, Alex Merry
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel