> On June 20, 2014, 1:17 p.m., Vishesh Handa wrote: > > I approve. > > > > The only problem I have is with the documentation, but we can improve that > > in another patch.
well let's improve directly. What do you think is missing with these new methods or is that more a general comment? - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118844/#review60588 ----------------------------------------------------------- On June 20, 2014, 12:01 p.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118844/ > ----------------------------------------------------------- > > (Updated June 20, 2014, 12:01 p.m.) > > > Review request for KDE Frameworks and Vishesh Handa. > > > Repository: kglobalaccel > > > Description > ------- > > Introduce convenient methods to set active and default shortcut > > Simplifies the setting of shorctus when default and active should be > the same or if only one shortcut is needed. > > > Diffs > ----- > > src/kglobalaccel.h d11881c89e889a77f47c1ba5db42db6ebef665b1 > src/kglobalaccel.cpp 54d18ecf918d4d0890c0a37aec10270119edd103 > > Diff: https://git.reviewboard.kde.org/r/118844/diff/ > > > Testing > ------- > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
