On 19/06/14 22:21, Marco Martin wrote: > Hi all, > I was thinking, since the policy for committing in frameworks is to always > asking for a review, what about on repositories under frameworks/* adding an > hook that accepts pushes only if the comment has a REVIEW: line? > > I have been guilty too many times of not respecting that, mostly for not > thinking about it at all, maybe I'm not the only one, an artificial enforce > of > discipline like that *may* make sense. > > opinions? would be useful, or mostly just an annoyance?
My main concern is the scripted changes that some of us occasionally do (especially David with the releasing). I don't think there's any point reviewing more than the first one or two such changes (and none at all for the release version updates). So how do we get those past such hooks? Alex _______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
