----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118768/#review60667 -----------------------------------------------------------
This review has been submitted with commit f6f1e8c7b8321389fe8268fc25254bd512a6f399 by Alex Merry to branch master. - Commit Hook On June 15, 2014, 6:54 p.m., Alex Merry wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118768/ > ----------------------------------------------------------- > > (Updated June 15, 2014, 6:54 p.m.) > > > Review request for Build System, Extra Cmake Modules and KDE Frameworks. > > > Repository: extra-cmake-modules > > > Description > ------- > > ECMAddTests: make NAME_PREFIX only apply to the test, not the target > > David Faure and Patrick Spendrin have convinced me that NAME_PREFIX > should be informational only, and not be used to prevent clashes, since > it makes things confusing when you run tests manually. > > > Diffs > ----- > > modules/ECMAddTests.cmake 6cc20b65e25df02be6a91ac6004142d6b0f9e307 > > Diff: https://git.reviewboard.kde.org/r/118768/diff/ > > > Testing > ------- > > Built and tested frameworks. Some need patching up (kconfig and kio in > particular). I think the safest thing is to remove the use of NAME_PREFIX > from those, so that people don't have to update ECM in order to build them. > > Also, I should write some unit tests... > > > Thanks, > > Alex Merry > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
