> On June 26, 2014, 7:29 a.m., Thomas Lübking wrote: > > this is however not ABI relevant, so depending on schedules one *could* > > wait for some specified NETWM hint (to not cruft the lib with the gtk+ prop > > symbol: removing it from the enum is oc. not API stable, thus not possible) > > and be introduced even with KWin 5.0.3 or whatever the final name scheme > > will be ;-) > > Martin Gräßlin wrote: > yeah I'm fine with delaying to post 5.0 in frameworks. Means KWin 5.0 > will not have full support for it. But if it gets into KWindowSystem 5.1 we > can still add it in a minor KWin relase (and get killed by distros for > increasing requirement in a minor release :-P ).
if this is causing downstream dep issues, maybe a generic NETRootInfo::setSupported(const QString property) might be a good idea? - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118946/#review60994 ----------------------------------------------------------- On June 26, 2014, 7:22 a.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118946/ > ----------------------------------------------------------- > > (Updated June 26, 2014, 7:22 a.m.) > > > Review request for KDE Frameworks and kwin. > > > Repository: kwindowsystem > > > Description > ------- > > Adding property _GTK_SHOW_WINDOW_MENU to NET::Properties2 > > Although non-standard it needs to be added to the NET::PRoperties2 > in order to have KWin announce it in the supported section. > > As soon as this gets standardized WM2ShowWindowMenu can be changed > to point to both the proprietary GTK hint and the standardized hint. > > > Diffs > ----- > > autotests/netrootinfotestwm.cpp f8c28be51e5a5b19d436c54eede0e8659a65c84e > src/netwm.cpp 1daad1e5fc87fa85da6348a059d0ae0acec26eaf > src/netwm_def.h 0edadc085e08531ec81bcde5651e8475e8573091 > > Diff: https://git.reviewboard.kde.org/r/118946/diff/ > > > Testing > ------- > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
