> On June 30, 2014, 9:01 a.m., Martin Gräßlin wrote: > > src/kwindowinfo_x11.cpp, line 301 > > <https://git.reviewboard.kde.org/r/119008/diff/2/?file=285388#file285388line301> > > > > are you sure it's Latin1? Normally string properties are utf8.
Well, since those are UUIDs, it does not make a difference. I put latin1 since it is (seems) a slightly faster conversion. I have nothing against changing it to uft8 if you want. - Ivan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119008/#review61256 ----------------------------------------------------------- On June 30, 2014, 8:22 a.m., Ivan Čukić wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119008/ > ----------------------------------------------------------- > > (Updated June 30, 2014, 8:22 a.m.) > > > Review request for KDE Frameworks, kwin and Martin Gräßlin. > > > Repository: kwindowsystem > > > Description > ------- > > NETWindowInfo provides the information about activities a window belong to. > > libtaskmanager uses it through kde4support. > Since there is a new client that needs this information (activity switcher), > I think it should go into the main API. > > > Diffs > ----- > > src/kwindowinfo.h e9b7a0a > src/kwindowinfo.cpp 3095932 > src/kwindowinfo_p.h 4c26c62 > src/kwindowinfo_p_x11.h 2acb3f8 > src/kwindowinfo_x11.cpp 87a887c > > Diff: https://git.reviewboard.kde.org/r/119008/diff/ > > > Testing > ------- > > Yes > > > Thanks, > > Ivan Čukić > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel