----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119005/#review61287 -----------------------------------------------------------
This seems wrong to me. QSettings is not a desktop file parser. It will get escaping wrong, compared to what the desktop entry spec says. Isn't the long term solution to write .json files directly anyway? - David Faure On June 29, 2014, 5:59 p.m., Alexander Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119005/ > ----------------------------------------------------------- > > (Updated June 29, 2014, 5:59 p.m.) > > > Review request for KDE Frameworks and Sebastian Kügler. > > > Repository: kservice > > > Description > ------- > > It now uses QSettings to read the desktop file instead of kconfig which > means that this tool could move to kcoreaddons. > > > Diffs > ----- > > src/desktoptojson/CMakeLists.txt 134dabe62ca051eea26631aedc72b108e1b60444 > src/desktoptojson/kconfigtojson.cpp > 5c0d751f05503e471ed9c49efc51bfdd22774be9 > > Diff: https://git.reviewboard.kde.org/r/119005/diff/ > > > Testing > ------- > > now includes all fields (Comment + Comment[de] + Comment[...], etc) > > I guess desktoptojson could be move to kcoreaddons for 5.1 and have > kservice_desktop_to_json forward to a new kcoreaddons_desktop_to_json for > cmake source compatibility > > > Thanks, > > Alexander Richardson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel