----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119037/#review61368 -----------------------------------------------------------
Ship it! Looks good, just two minor things. src/BackendsManager.cpp <https://git.reviewboard.kde.org/r/119037/#comment42731> ah "path" is what contains the subdir. A bit confusing at first read, I'd suggest renaming the "path" variable to "subdir"... src/BackendsManager.cpp <https://git.reviewboard.kde.org/r/119037/#comment42732> unused var - David Faure On July 1, 2014, 10:49 a.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119037/ > ----------------------------------------------------------- > > (Updated July 1, 2014, 10:49 a.m.) > > > Review request for KDE Frameworks and Vishesh Handa. > > > Repository: kauth > > > Description > ------- > > So far we were looking at relative directories to the install prefix, and it > was never finding anything. The reason it didn't find anything is that nobody > had tested kauth before with a plugin. > > This patch changes this so we rebase those relative paths on top of the > QT_PLUGIN_PATH, so that we have a list of absolute paths to look for. > > > Diffs > ----- > > src/BackendsManager.cpp d63fb25 > src/CMakeLists.txt 9fed6f2 > src/ConfigureChecks.cmake e57873e > > Diff: https://git.reviewboard.kde.org/r/119037/diff/ > > > Testing > ------- > > When I launch "kcmshell5 clock", I get a crash because the backend is loaded > and it crashes. > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
