----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119079/ -----------------------------------------------------------
Review request for KDE Frameworks. Repository: kcoreaddons Description ------- This class simplifies reading the metadata from a qt plugin by providing type safe accessor functions for the standard plugininfo keys that are also used by the .desktop file based KPluginInfo KPluginMetaData: Read the translated value for name and description The "Name" and "Comment" fields of the metadata should be translated since they will be shown to the user (e.g. in the plugin selection dialog) Add a unit test for KPluginMetaData Add KPluginMetaData::findPlugins() Add a unit test for KPluginMetaData::findPlugins() Diffs ----- autotests/CMakeLists.txt 75d12932b36fcfe4ae1d538176ef9f85f60f15dd autotests/kpluginmetadatatest.cpp PRE-CREATION src/lib/CMakeLists.txt 26eb5a1d4d56742a3395ba2645290bea15aee181 src/lib/plugin/kpluginmetadata.h PRE-CREATION src/lib/plugin/kpluginmetadata.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/119079/diff/ Testing ------- Added a unit test Should easily allow loading all plugins from a given directory without needing kbuildsycoca Thanks, Alexander Richardson
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
