On Thursday 03 July 2014 19:50:35 laurent Montel wrote: > Hi, > During kdepim porting I saw that it was not possible to add a ActionButton > as QButtonBox is protected. > => we can do it if we create a derived class. > But it’s not a very easy method for just add a button. > > I would like to add a new method to do it. > I created a patch for it. > > What do you think about it ? > > (Example when we need to add a ActionButton, it’s when we have a old "User1" > button).
Looks OK to me. Will it come with an automated test? We should get serious about that in our reviews as well, and I know you've the necessary testing-fu to get this simple case properly tested. ;-) Regards. -- Kévin Ottens, http://ervin.ipsquad.net KDAB - proud supporter of KDE, http://www.kdab.com
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Kde-frameworks-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
