----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119142/ -----------------------------------------------------------
(Updated July 6, 2014, 10:09 p.m.) Status ------ This change has been marked as submitted. Review request for KDE Frameworks, Alex Merry and Kevin Ottens. Repository: kxmlgui Description ------- KXMLGUI: load .rc files from DATADIR/kxmlgui5/component_name/file.rc The old files (DATADIR/component_name/file.rc) can still be loaded, and a runtime warning is shown in such a case, telling people to install into KXMLGUI_INSTALL_DIR (ECM patch posted to k-f-d) This keeps DATADIR slightly cleaner, getting rid of many application subdirs that would just contain a rc file. Some people seem to care about the cleanliness of their DATADIR :-) REVIEW: 119142 Diffs ----- src/kedittoolbar.cpp 32512e9caccdbee1b07ff791fbecdcc817ca5726 src/kxmlguiclient.h 2331b6934f99528c5d266c92d78a8affaccad2a0 src/kxmlguiclient.cpp f7c90b261645dfe2efeb2edbc8f32cb134fc9b7d src/kxmlguifactory.cpp aa657bcc24a949f4350975609f19fae8b6c9a4f0 Diff: https://git.reviewboard.kde.org/r/119142/diff/ Testing ------- Running kwrite unmodified -> works, with runtime warning Porting kwrite to KXMLGUI_INSTALL_DIR -> works, runtime warning is gone I also did the same with konsole, special case since it called setXMLFile("konsole/partui.rc"), had to be ported to setComponentName("konsole") + setXMLFile("partui.rc") while porting to KXMLGUI_INSTALL_DIR. This patch is still SC/BC, it's just a porting trap -- that affects none of the other existing kf5-based apps though. Thanks, David Faure
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
