----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119251/#review62209 -----------------------------------------------------------
src/lib/kaboutdata.h <https://git.reviewboard.kde.org/r/119251/#comment43252> Normally, it goes before the return type. It presumably still works where you put it, but it looks very odd. - Alex Merry On July 12, 2014, 7:02 p.m., Cristian Oneț wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119251/ > ----------------------------------------------------------- > > (Updated July 12, 2014, 7:02 p.m.) > > > Review request for KDE Frameworks and kdewin. > > > Repository: kcoreaddons > > > Description > ------- > > On MSVC this could cause a compile error if the compiler would see the > forward declaration first because it would consider it a redefinition with > different linkage. > > Found while cbuilding KDELibs4Support on Windows using MSVC, see > https://git.reviewboard.kde.org/r/119249/ > > > Diffs > ----- > > src/lib/kaboutdata.h f0f3e12bf353019d86f582416cec90390de00f88 > > Diff: https://git.reviewboard.kde.org/r/119251/diff/ > > > Testing > ------- > > Build with MSVC 2013 on Windows and gcc-4.8.3 on Linux. > > > Thanks, > > Cristian Oneț > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel