----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119259/#review62250 -----------------------------------------------------------
Ship it! A note for the future: your "Testing done" field suggests you haven't tried running the tests. Running "make test" to check your changes is always a good idea. I applied your patch to my checkout, and they ran fine, though, so you can ship it. - Alex Merry On July 13, 2014, 11:19 a.m., Andreas Xavier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119259/ > ----------------------------------------------------------- > > (Updated July 13, 2014, 11:19 a.m.) > > > Review request for KDE Frameworks, Alex Merry and David Faure. > > > Repository: kservice > > > Description > ------- > > When compiling framworks following > https://community.kde.org/Frameworks/Building/Details, I was unable to > compile kservice. I think that the problem was the typo nsapluginfa for > nsaplugin. This patch fixes that. > > > Diffs > ----- > > autotests/nsaplugin.cpp 48aeaf4 > > Diff: https://git.reviewboard.kde.org/r/119259/diff/ > > > Testing > ------- > > Compiled. > > > Thanks, > > Andreas Xavier > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel