----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119457/#review63113 -----------------------------------------------------------
Ship it! Thank you, you are awesome! A couple of notes about your test repo (for the benefit of your future porting efforts): ${ECM_KDE_MODULE_DIR} is contained in ${ECM_MODULE_PATH}, and so shouldn't be added to the CMAKE_MODULE_PATH, and DATA_INSTALL_DIR won't be defined if you don't include KDEInstallDirs (and you should be using CMAKE_INSTALL_DATADIR anyway, really). I had to replace ${DATA_INSTALL_DIR} with share/icons to test installation. - Alex Merry On July 25, 2014, 2:49 a.m., David Narváez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119457/ > ----------------------------------------------------------- > > (Updated July 25, 2014, 2:49 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kde-dev-scripts > > > Description > ------- > > The script > 1) Fixes icon categories when found wrong, eg. action -> actions > 2) Renames icons to remove theme prefix > 3) Rewrites the CMakeLists.txt file to install icons grouped by themes > > It does not support l10n codes. > > > Diffs > ----- > > kf5/fix-ecm-install-icons.pl PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/119457/diff/ > > > Testing > ------- > > 1) Unpack the attached test repository > 2) Configure the repository using cmake - should display warnings > 3) Fix the CMakeLists.txt file using this script > 4) Reconfigure the repository using cmake - warnings should be gone > > > File Attachments > ---------------- > > Test Repository > > https://git.reviewboard.kde.org/media/uploaded/files/2014/07/25/f598db77-95a6-4505-b02d-72304b79d65b__iconstest.tgz > > > Thanks, > > David Narváez > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel