----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119871/#review64935 -----------------------------------------------------------
Ship it! Actually, I see no reason why it should make things worse. src/kmultitabbar.cpp <https://git.reviewboard.kde.org/r/119871/#comment45367> Remove empty line - Christoph Feck On Aug. 20, 2014, 8:02 p.m., Hugo Pereira Da Costa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119871/ > ----------------------------------------------------------- > > (Updated Aug. 20, 2014, 8:02 p.m.) > > > Review request for KDE Frameworks, Christoph Feck and Gilles Caulier. > > > Repository: kwidgetsaddons > > > Description > ------- > > With both breeze and oxygen, the multitabbar tab buttons had visual glitches > when pressed/hovered/focused, etc. > > See for instance Kate. > > This is due to an inconsistency in the option->state set in initStyleOption. > State_AutoRaise is passed in mouse-over mode, and not passed in normal mode. > Now, > 1/ styles might not have the same margins, offsets, etc. for autoraised and > flat toolbuttons > 2/ the mouseover state might not be the same at the time ::sizeHint is called > and at the time ::paintevent is called. > So you can get random rendering issues, due to typically the widget size not > being what is expected by the style to paint. > > Easy fix is to always set the state as autoraise (which makes sense for this > 'custom' toolbar. > > PS: Christoph, I'd like to add groups instead of reviewers, but am really > confused about how this works in kf5 days ... > > PS2: I can try add screenshots if necessary > > > Diffs > ----- > > src/kmultitabbar.cpp 0420bec > > Diff: https://git.reviewboard.kde.org/r/119871/diff/ > > > Testing > ------- > > With oxygen, breeze and fusion. > No more issues > > > Thanks, > > Hugo Pereira Da Costa > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel