----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119876/ -----------------------------------------------------------
(Updated Aug. 21, 2014, 7:41 a.m.) Review request for KDE Frameworks. Changes ------- port the msgbox to KIO::JobUiDelegate.askDeleteConfirmation() Repository: kio Description (updated) ------- This allows to remove duplicated code in kfileplacesview (kio), libkonq (dolphin, homerun), dolphin's placespanel, ktrash, plasma's trash applet, krusader, plasma-mobile's filebrowser. All of them had to duplicate the magic KIO::special call with hardcoded value 1. This commit makes KFilePlacesView use KIO::emptyTrash() and KIO::JobUiDelegate.askDeleteConfirmation() for the msgbox. REVIEW: 119876 Diffs (updated) ----- src/core/emptytrashjob.h PRE-CREATION src/core/emptytrashjob.cpp PRE-CREATION src/filewidgets/kfileplacesview.h ace7350f87d212d877aaa9a29f852e028ca387a8 src/core/CMakeLists.txt 1c24d62eaac4a4b448d0cc07dd61fd9d1bda0dff src/filewidgets/kfileplacesview.cpp 543dfd04d39f6ce93a0852705967624f00b142d5 Diff: https://git.reviewboard.kde.org/r/119876/diff/ Testing ------- frameworkintegration/tests/qfiledialogtest, to bring up KFileWidget with its places view, RMB, empty trash -> worked. No unit tests possible, even with a different XDG_DATA_HOME it would find the user's trash dirs on other partitions and empty them. Thanks, David Faure
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
